Lazyyy #105
Lazyyy #105
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| elif (arg & 2) and argrepr: | ||
| argrepr = f"{argrepr} + eager" | ||
| else: | ||
| print(deop) |
There was a problem hiding this comment.
Bug: Debug Print in Opcode Argument Handling
A debug print(deop) statement was accidentally left in the code. It prints to stdout during normal disassembly whenever an opcode's argument processing falls into the general else branch.
| if (attr == Py_None) { | ||
| attr = NULL; | ||
| } | ||
| assert(!attr || PyObject_IsTrue(attr)); |
There was a problem hiding this comment.
Bug: Lazy Import Assertion Masks Errors
The assertion !attr || PyObject_IsTrue(attr) in _PyLazyImport_New doesn't correctly handle PyObject_IsTrue() returning -1 on error. Because -1 is truthy in C, the assertion passes, silently masking any exception set by PyObject_IsTrue().
| ERROR_IF(res_o == NULL); | ||
| //PyStackRef_CLOSE(*res); | ||
| *res = PyStackRef_FromPyObjectSteal(res_o); | ||
| } |
There was a problem hiding this comment.
Bug: Lazy Import Reference Leak
Reference leaks occur in LOAD_NAME and LOAD_GLOBAL instructions when handling lazy import objects. When a lazy import is resolved, its original reference is not properly released before being replaced by the loaded module, leading to a memory leak. The commented-out PyStackRef_CLOSE in LOAD_GLOBAL indicates this missing cleanup.
No description provided.